Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spuriously occuring crashes of the GobView tests automated with Selenium are due to a race. The race can be forced by letting the goblint-http server sleep for 10s before returning e.g.
stats.marshalled
.When the GobView page is loaded, it first displays a spinner. After all files necessary for the initialization are marshalled including
stats.marshalled
), the DOM element with the spinner is updated (through React) to display the actual web page. The callbrowser.get(url)
in the python selenium test opens the web page of the url and waits for the page to be loaded. Waiting for it to be loaded here means, that the propertydocument.readyState
will becomplete
before the next statement in the test is executed. This does however not indicate whether the page is fully loaded, dynamic updates through React might still happen afterdocument.readyState == complete
. The condition can be fulfilled even though the spinner is still being displayed.This PR
Closes #1085