Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for mutex-meet-tid for ValidDeref & Move Afterconfig.run to ensure privatizations can potentially be auto-tuned #1265

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

michael-schwarz
Copy link
Member

@michael-schwarz michael-schwarz commented Nov 22, 2023

For tasks such as the example one, we fail to establish Valid-Deref for the reason that our information about globals is too imprecise. With this PR we enable a more involved privatization when checking ValidDeref.

I am currently running this on the server with a reduced timeout of 4mins to see the potential benefits.

@michael-schwarz michael-schwarz added sv-comp SV-COMP (analyses, results), witnesses precision labels Nov 22, 2023
@michael-schwarz
Copy link
Member Author

For some reason, the setting is not applied correctly.

./goblint --conf conf/svcomp.json --sets ana.specification /home/michael/Documents/sv-comp/sv-benchmarks/c/properties/valid-memsafety.prp --sets exp.architecture 32bit 2.c

fails

but

./goblint --conf conf/svcomp.json --sets ana.specification /home/michael/Documents/sv-comp/sv-benchmarks/c/properties/valid-memsafety.prp --sets exp.architecture 32bit 2.c --set ana.base.privatization mutex-meet-tid

works.

@michael-schwarz
Copy link
Member Author

It seems the autotuner needs to run earlier.

src/analyses/base.ml Outdated Show resolved Hide resolved
@michael-schwarz
Copy link
Member Author

Enabling the option does not yield a large improvement, and takes a long time. I'll thus remove the activation from this PR.

diff.zip

@michael-schwarz michael-schwarz changed the title Enable mutex-meet-tid for ValidDeref Test for mutex-meet-tid for ValidDeref & Move Aftercofnig.run to ensure privatizations can potentially be auto-tuned Nov 22, 2023
@michael-schwarz michael-schwarz added this to the v2.4.0 milestone Nov 22, 2023
@michael-schwarz michael-schwarz changed the title Test for mutex-meet-tid for ValidDeref & Move Aftercofnig.run to ensure privatizations can potentially be auto-tuned Test for mutex-meet-tid for ValidDeref & Move Afterconfig.run to ensure privatizations can potentially be auto-tuned Nov 22, 2023
@michael-schwarz michael-schwarz merged commit 24943a1 into master Nov 27, 2023
17 checks passed
@michael-schwarz michael-schwarz deleted the mutex-meet-tid-memsafety branch November 27, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
precision sv-comp SV-COMP (analyses, results), witnesses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants