Refactor Apron Printables
#1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-schwarz
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
I have not checked whether this fixes the performance issues described in #1513, but it seems reasonable to have it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a fix to my observation that Apron output is always line broken with 80 column margin from
Formatby default #1513 (comment).This avoids completely arbitrary line breaks (which may still go over column 80 in indented output line tracing) which also make searching the tracing files more annoying. At the same time, it might bypass #1513 (of course we should still optimize it in CIL as well).
This also cleans up other
Printable-like things in Apron domains by adding the functions intoGobApron.