Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some improvements from the #281 proposal have been implemented by @sio4 some nice options to improve the PG dialog have been opened.
lib/pg
by default converts any provided URL type of string into specific connection string.gobuffalo/pop
by default parses the URL for PG. In practice, that means any attempt to use connection format string will fail due to the URL parsing something that's not a URL.Notably, that also affects Google Cloud SQL, which uses the mentioned string format to connect.
Rationale and previous "quick fix" can be seen here: #281 (comment)
This PR:
ConnectionDetails.Options