Rebase from upstream #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the rubocop generated configuration to ignore any major changes that can't be auto-corrected.
Augment the existing operations with Prometheus metrics in order to provide observability around the operations that the plugin is performing. Introduce a new metrics helper to prevent attempting to register the same metric more than once in a multi-threaded or multi-instance context.
As per the README updates, this can be used to compress a number of input records into a single Pub/Sub message, therefore saving on costs.
Clarify that the published bytes value is before compression. Correct the name of the name of the compression ratio metric.
This should now allow us to run with the latest ruby 3.1.3
DragosDumitrache
force-pushed
the
update-gem-dependencies
branch
3 times, most recently
from
402424b to
ea930b0
Compare
DragosDumitrache
force-pushed
the
update-gem-dependencies
branch
from
ea930b0 to
3abe166
Compare
DragosDumitrache
force-pushed
the
update-gem-dependencies
branch
from
b0cb12a to
4f88a59
Compare
DragosDumitrache
force-pushed
the
update-gem-dependencies
branch
from
4f88a59 to
249539d
Compare
added 5 commits
February 6, 2023 15:43
Also automatically apply all fixes that rubocop suggested
|
Closing this, as this will be completed at a later date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.