CI-1852: Update to a more modern ruby version #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to using Ruby 3.1.3 and updated our gem dependencies Committed the Gemfile.lock as it's typically good practice to ensure replicable builds Prometheus client had a breaking API change so we have to add named arguments properly now Had to use named arguments for counters as well as histograms Also updated rubocop to use cops appropriate to the ruby version being used
DragosDumitrache
force-pushed
the
CI-1852-update-ruby
branch
2 times, most recently
from
87affd1 to
31feec4
Compare
DragosDumitrache
force-pushed
the
CI-1852-update-ruby
branch
from
31feec4 to
5faa8f7
Compare
| @@ -0,0 +1,31 @@ | |||
| name: Test | |||
There was a problem hiding this comment.
Copied from upstream, only change is adding our main branch to be gocardless
There was a problem hiding this comment.
this i'm assuming will be removed when we move the code back to upstream i guess?
| @@ -1,43 +1,60 @@ | |||
| --- | |||
| # This configuration was generated by | |||
There was a problem hiding this comment.
Generated by rubocop, all standard
Comment on lines
58
to
+61
| :"#{metric_prefix}_messages_compression_duration_seconds", | ||
| "Time taken to compress a batch of messages", | ||
| {}, | ||
| [0, 0.0001, 0.0005, 0.001, 0.01, 0.05, 0.1, 0.25, 0.5, 1], | ||
| docstring: "Time taken to compress a batch of messages", | ||
| buckets: [0, 0.0001, 0.0005, 0.001, 0.01, 0.05, 0.1, 0.25, 0.5, 1], | ||
| labels: [:topic, :algorithm] |
There was a problem hiding this comment.
these is because of a breaking change on their side i guess?
There was a problem hiding this comment.
Yep, a former GC person made this change but we've never updated this on our side
kevinrobayna
approved these changes
Feb 24, 2023
DragosDumitrache
added a commit
that referenced
this pull request
Feb 24, 2023
* Update to a more modern version of ruby Moved to using Ruby 3.1.3 and updated our gem dependencies Prometheus client had a breaking API change so we have to add named arguments properly now Had to use named arguments for counters as well as histograms Also updated rubocop to use cops appropriate to the ruby version being used * Add CI pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to using Ruby 3.1.3 and updated our gem dependencies
Prometheus client had a breaking API change so we have to add named
arguments properly now
Had to use named arguments for counters as well as histograms
Also updated rubocop to use cops appropriate to the ruby version being used
For context on named arguments:
prometheus/client_ruby@160c25e