Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock the parent object to prevent deadlocks updating most_recent #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/statesman/adapters/active_record.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def create_transition(from, to, metadata)

transition = transitions_for_parent.build(transition_attributes)

::ActiveRecord::Base.transaction do
@parent_model.with_lock do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to lock here (around the whole transaction) rather than just around unset_most_recent?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is probably the best option. Any locks acquired will be held until the end of the transaction anyway (I think).

@observer.execute(:before, from, to, transition)
unset_old_most_recent
transition.save!
Expand Down