Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reason mandatory when interactive #336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

doomholderz
Copy link

Making reason entry mandatory on interactive console creations

@benwh
Copy link
Contributor

benwh commented Dec 8, 2024

While I'm no longer a maintainer on this repo, I can provide some historical context:

The runner package in this repo was designed to be relatively un-opinionated, mostly as an inspiration and something that you could use when developing against theatre. At GoCardless (and incident.io) we imported this package into our own CLI, and only in those CLI's would we encode organisation-specific logic like requiring a reason.

I don't think it's practical for anyone to be using the runner CLI here for their own organisation, given that it's not packaged and distributed nicely, hence I'd be against putting org-specific requirements into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants