Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply command option from environment values #371

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Apply command option from environment values #371

merged 1 commit into from
Dec 10, 2024
+2 −2

Conversation

osamingo
Copy link
Contributor

@osamingo osamingo commented Dec 10, 2024 •
edited
Loading

What

  • Apply command option from environment values
  • If both are specified, long takes precedence (this depends on the behavior of jessevdk/go-flags and may be changed by this libs update)

Why

  • When we use GitHub Actions, we can't take arguments, so we need to pass the value in an environment variable

@goccy goccy merged commit 4676a5c into goccy:main Dec 10, 2024
4 checks passed
@goccy
Copy link
Owner

goccy commented Dec 10, 2024

Thank you for your contribution !!! LGTM 👍

@osamingo osamingo deleted the apply-opts-from-env-values branch December 10, 2024 15:05
@BrewTestBot BrewTestBot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osamingo @goccy