Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): inconsistent paths single-line MappingKeyValueNode #612

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

LarsStegman
Copy link
Contributor

Fixes #583

I am writing a YAML transformer and this path inconsistency was standing in my way.

I am not sure how to extend the current test suite for this fix.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.22%. Comparing base (df5e06f) to head (4b9fceb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   77.21%   77.22%           
=======================================
  Files          22       22           
  Lines        7870     7871    +1     
=======================================
+ Hits         6077     6078    +1     
  Misses       1374     1374           
  Partials      419      419           

Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goccy
Copy link
Owner

goccy commented Jan 16, 2025

Thank you for your contribution !!

@goccy goccy merged commit 1c32d14 into goccy:master Jan 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MappingValue path not set correctly
3 participants