Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aggregate] Properly return nil for STRING_AGG when called with null or 0-length array #154

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

ohaibbq
Copy link
Contributor

@ohaibbq ohaibbq commented Feb 1, 2024

Previously we were returning empty string.

Closes #146

@ohaibbq ohaibbq changed the title [Aggreagate] Poroperly return nil for STRING_AGG when called with null or 0-length array [Aggregate] Properly return nil for STRING_AGG when called with null or 0-length array Feb 1, 2024
Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !!

@goccy goccy merged commit 4a17cdc into goccy:main Mar 9, 2024
6 checks passed
@ohaibbq ohaibbq deleted the dan/string-agg-nil branch March 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Aggregate] STRING_AGG returns "" when aggregating null
2 participants