-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Don't merge yet] Add release dates in release notes #966
base: master
Are you sure you want to change the base?
Conversation
@varshavaradarajan said it should be done on the downloads page too. Using the date from releases.json. That makes sense. Will do that tomorrow. Don't merge. |
Ping! pls see if this is still relevant. |
@kritika-singh3 - I think this can be closed. We added the release date to the downloads page. |
@varshavaradarajan I think the PR was to add the release dates on the release notes. Is it not required anymore? |
Nope. The downloads page makes a call and retrieves the releases.json. Which has the release date, so there is no manual step required. Here, when one edits the release notes, they need to remember and put that in. So, it's overkill. When the release date is already available on the downloads page. I don't think @arvindsv will do that anymore. :P |
@varshavaradarajan hmm. Agree with your logic. |
af440bb
to
06bcd36
Compare
06bcd36
to
457ec12
Compare
Looks like this:
Fixes #963
/cc @varshavaradarajan
Dates from: https://github.com/gocd/gocd/releases