Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis-CI build & simplify Makefile & fix README #33

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

hoijui
Copy link

@hoijui hoijui commented Apr 20, 2019

see commits for details

@petar
Copy link
Member

petar commented Apr 21, 2019

This looks good. Thank you. The only issue is that syscall.Dup3 does not compile on my machine:
go version go1.12.4 darwin/amd64

To solve this issue, could you add a separate sigpanic_save_panic_trace.go for darwin and linux, perhaps?

On windows, we use totally different code,
not using any `syscall.Dup*` calls.
@hoijui
Copy link
Author

hoijui commented Apr 21, 2019

Did that (I think).

@hoijui
Copy link
Author

hoijui commented Apr 21, 2019

ah.. I just saw that there are 4 arm archs:

  • arm
  • armbe
  • arm64
  • arm64be

reference

would I have to define all of them in the +build coment, or does arm stand for all of them?
@ericvh Can you please test if this code still compiles for you?

Edit: It shoul'd work for arm64 now too

@hoijui
Copy link
Author

hoijui commented May 17, 2019

as it is now, syscall.Dup3 will only be used on ARM archs, so for you it will still use syscall.Dup2. The latest commit adds windows and OSX builds to Travis-CI, and they compile fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants