Mocha test fixes (#947)

* fix: add babel/preset-react for react projects * fix: common lint catches
godaddy · Oct 17, 2024 · 9e19300 · 9e19300
1 parent 8c95c49
commit 9e19300
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/packages/gasket-plugin-mocha/lib/index.js b/packages/gasket-plugin-mocha/lib/index.js
@@ -64,8 +64,9 @@ const plugin = {
 
           pkg.add('devDependencies', {
             // All dependencies to correctly configure React Testing Library
-            'jsdom': devDependencies.jsdom,
+            '@babel/preset-react': devDependencies['@babel/preset-react'],
             '@testing-library/react': devDependencies['@testing-library/react'],
+            'jsdom': devDependencies.jsdom,
             'global-jsdom': devDependencies['global-jsdom'],
             [name]: `^${version}`
           });

diff --git a/packages/gasket-plugin-mocha/test/index.test.js b/packages/gasket-plugin-mocha/test/index.test.js
@@ -166,8 +166,9 @@ describe('Plugin', () => {
     });
 
     [
-      'global-jsdom',
+      '@babel/preset-react',
       '@testing-library/react',
+      'global-jsdom',
       'jsdom'
     ].forEach(name => {
       it(`adds "${name}" in the devDependencies`, async function () {

diff --git a/packages/gasket-plugin-nextjs/generator/jest/pages-router/test/index.spec.js b/packages/gasket-plugin-nextjs/generator/jest/pages-router/test/index.spec.js
@@ -12,7 +12,7 @@ describe('IndexPage', () => {
   it('renders page', () => {
     render(
 {{#if hasGasketIntl}}
-      <IntlProvider locale={'en-US'} messages={messages}>
+      <IntlProvider locale={ 'en-US' } messages={ messages }>
 {{/if}}
       <IndexPage />
 {{#if hasGasketIntl}}

diff --git a/packages/gasket-plugin-nextjs/generator/jest/pages-router/test/index.spec.tsx b/packages/gasket-plugin-nextjs/generator/jest/pages-router/test/index.spec.tsx
@@ -12,7 +12,7 @@ describe('IndexPage', () => {
   it('renders page', () => {
     render(
 {{#if hasGasketIntl}}
-      <IntlProvider locale={'en-US'} messages={messages}>
+      <IntlProvider locale={ 'en-US' } messages={ messages }>
 {{/if}}
       <IndexPage />
 {{#if hasGasketIntl}}

diff --git a/packages/gasket-plugin-nextjs/generator/mocha/pages-router/test/pages/index.test.js b/packages/gasket-plugin-nextjs/generator/mocha/pages-router/test/pages/index.test.js
@@ -19,7 +19,7 @@ describe('IndexPage', () => {
   it('renders page', () => {
     render(
 {{#if hasGasketIntl}}
-      <IntlProvider locale={'en-US'} messages={messages}>
+      <IntlProvider locale={ 'en-US' } messages={ messages }>
 {{/if}}
       <IndexPage />
 {{#if hasGasketIntl}}

diff --git a/packages/gasket-plugin-nextjs/generator/mocha/pages-router/test/pages/index.test.tsx b/packages/gasket-plugin-nextjs/generator/mocha/pages-router/test/pages/index.test.tsx
@@ -19,7 +19,7 @@ describe('IndexPage', () => {
   it('renders page', () => {
     render(
 {{#if hasGasketIntl}}
-      <IntlProvider locale={'en-US'} messages={messages}>
+      <IntlProvider locale={ 'en-US' } messages={ messages }>
 {{/if}}
       <IndexPage />
 {{#if hasGasketIntl}}