Skip to content

Commit

Permalink
fix: Update WebpackContext Types (#955)
Browse files Browse the repository at this point in the history
  • Loading branch information
kbader-godaddy authored Oct 31, 2024
1 parent 90fec87 commit c4e86cf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/gasket-plugin-webpack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Adds Webpack support to your application.

## Installation

```
```sh
npm i @gasket/plugin-webpack
```

Expand Down Expand Up @@ -53,7 +53,7 @@ const initialConfig = { };
// Any additional context such as isServer or not
const context = { isServer: true };

const webpackConfig = actions.gasket.getWebpackConfig(initialConfig, context);
const webpackConfig = gasket.actions.getWebpackConfig(initialConfig, context);
```

This action will execute the `webpackConfig` lifecycle and return the final
Expand Down
5 changes: 4 additions & 1 deletion packages/gasket-plugin-webpack/lib/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ export interface WebpackMetrics {

declare module '@gasket/core' {
export interface GasketActions {
getWebpackConfig: (config: Configuration, context: WebpackContext) => Configuration
getWebpackConfig: (
config: Configuration,
context: Omit<WebpackContext, 'webpack'>
) => Configuration;
}

export interface HookExecTypes {
Expand Down

0 comments on commit c4e86cf

Please sign in to comment.