-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pydantic v2 #91
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 90.73% 91.12% +0.38%
==========================================
Files 2 2
Lines 205 214 +9
==========================================
+ Hits 186 195 +9
Misses 19 19
☔ View full report in Codecov by Sentry. |
Looking pretty good to me. Will ask some feedback from other maintainers as well. |
a715889
to
3a38fe1
Compare
Thanks, updated the isort problem 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice addition.
Great, thank you very much for the really quick response 🙏🙏🙏 |
@sharonyogev Just made a new release for you. |
@timvancann I think you force push some commits that removed this merged PR... |
This add support for pydantic v2 without dropping support to pydantic v1
I would love this to be merged soon so I can upgrade pydantic in my project