-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include results from integration test of archive db based cooperation #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies are not to be installed on the airflow container anymore, hence we have to resolve dependencies in the tasks that are run on the dask workers.
cherusk
force-pushed
the
godon_cooperative_integration_remediation
branch
from
November 17, 2023 18:09
140dd28
to
c613d33
Compare
Those need access to the dags and have to have airflow preinstalled.
To be compatible with preinstalled components.
cherusk
force-pushed
the
godon_cooperative_integration_remediation
branch
from
November 18, 2023 22:34
f073a1c
to
398e9c1
Compare
Keep objective seperate and include it in the optuna submitting code paths. Keeping it in the submitting code path is important otherwise the function pickling of recent dask distributed will fail that it cannot find the root dag module at unpickling side, the dask worker.
cherusk
force-pushed
the
godon_cooperative_integration_remediation
branch
from
November 19, 2023 12:45
7f839e1
to
108a614
Compare
Let's not use sqlalchemy to generate the archive db interacting sql queries because that has led to complications. bindparams was not working as expect for String/Text type.
cherusk
force-pushed
the
godon_cooperative_integration_remediation
branch
from
November 19, 2023 16:03
699a958
to
e8f07a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.