Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unimplemented static variant functions 'blend' and 'interpolate'… #1626

Merged

Conversation

ruffenman
Copy link
Contributor

If a user attempts to call either of these it will introduce a linker error and it may not be immediately clear to them why. Also, variant interpolation can already be accessed via 'UtilityFunctions::lerp', making at least the interpolate function unnecessary here.

…e'. If a user attempts to call either of these it will introduce a linker error and it may not be immediately clear to them why. Also, variant interpolation can already be accessed via 'UtilityFunctions::lerp', making at least the interpolate function unecessary here.
@ruffenman ruffenman requested a review from a team as a code owner October 15, 2024 00:36
@dsnopek dsnopek added bug This has been identified as a bug cherrypick:4.2 cherrypick:4.3 labels Oct 29, 2024
@dsnopek dsnopek added this to the 4.x milestone Oct 29, 2024
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I looks like Godot doesn't have these functions on its version of Variant, so I think removing them is the right way to go.

@dsnopek dsnopek merged commit 688ed4b into godotengine:master Oct 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug cherrypick:4.2 cherrypick:4.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants