Update for GDExtension interface changes in Godot 4.5 #1792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
the
enhancement
dsnopek
force-pushed
the
gdextension-interface-45
branch
from
fdcbf5d to
bb349af
Compare
dsnopek
force-pushed
the
gdextension-interface-45
branch
from
bb349af to
f402a21
Compare
Ivorforce
approved these changes
Jun 20, 2025
Comment on lines
+270
to
+272
| void register_startup_callback(GDExtensionMainLoopStartupCallback p_callback) const; | ||
| void register_frame_callback(GDExtensionMainLoopFrameCallback p_callback) const; | ||
| void register_shutdown_callback(GDExtensionMainLoopShutdownCallback p_callback) const; |
There was a problem hiding this comment.
These could use a comment, when (and why) exactly they're called in context of other functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
gdextension_interface.hto match what's currently in Godotmaster(and will become part of Godot 4.5), and also attempts to make use of the newer functions, such that we aren't using any deprecated functions.I also added support for the startup, frame and shutdown callbacks from PR godotengine/godot#106030
This allowed me to test that those callbacks work as expected, although, I didn't add any automated tests using them in this PR, since I'm not sure how we could effectively do that.
The comment changes ingdextension_interface.hfrom PR godotengine/godot#107594 are included here as well, so this shouldn't be merged until after that PR is.UPDATE: That PR was merged! This PR has been updated with the latest version from it.
Fixes #1791