Tested and Fixed Pong with GDScript Demo for 4.0-dev #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
Apr 3, 2022
2d/pong/README.md
Outdated
| @@ -6,7 +6,7 @@ for game development in Godot, including | |||
|
|
|||
| Language: GDScript | |||
|
|
|||
| Renderer: GLES 2 | |||
| Renderer: Vulkan | |||
There was a problem hiding this comment.
If we're updating this text, we should be specifying if it's Vulkan Clustered or Vulkan Mobile.
Additionally, we should be setting demos to Vulkan Mobile if it doesn't look any different compared to Vulkan Clustered. Especially for GUI-only demos, they will look the same in Vulkan Mobile. Go to Project -> Project Settings -> General tab -> Rendering section -> Vulkan -> Back End -> Select Forward Mobile.
2d/pong/project.godot
Outdated
Comment on lines
24
to
25
| window/size/width=640 | ||
| window/size/height=400 |
There was a problem hiding this comment.
Suggested change
| window/size/width=640 | |
| window/size/height=400 | |
| window/size/viewport_width=640 | |
| window/size/viewport_height=400 |
There was a problem hiding this comment.
Thanks! This was something I missed in the settings, changed the settings, squashed and pushed.
Made the usual changes to the project settings and tested to see if everything works. Everything works fine! Small fixes Changed to Vulkan Mobile. Changed viewport size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the usual changes to the project settings and tested to see if
everything works.
Everything works fine!
Another task which can be checked of #697.