-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add some notes about importing meshes for use with SoftBody3D #11060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the page as is doesn't have the best formatting but you can't have endlessly long lines in the docs. You also had two spaces after periods for some reason, and I've removed a comma that doesn't flow well in my suggested change.
tutorials/physics/soft_body.rst
Outdated
|
||
When importing a 3D scene, you can use the **Save to File** option in the mesh import settings to save the mesh as a standalone resource file that you can then attach to ``SoftBody3D`` nodes. | ||
|
||
When importing a mesh for use with ``SoftBody3D``, you may also want to change the default LOD generation options. The default import settings will produce an LOD that merges adjacent faces that are nearly flat with respect to each other, even at very close render distances. This works well for static meshes, but is often undesirable for use with ``SoftBody3D``, if you want these faces to be able to bend and move with respect to each other, instead of being rendered as a single plane. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When importing a mesh for use with ``SoftBody3D``, you may also want to change the default LOD generation options. The default import settings will produce an LOD that merges adjacent faces that are nearly flat with respect to each other, even at very close render distances. This works well for static meshes, but is often undesirable for use with ``SoftBody3D``, if you want these faces to be able to bend and move with respect to each other, instead of being rendered as a single plane. | |
When importing a mesh for use with ``SoftBody3D``, you may also want to change the | |
default LOD generation options. The default import settings will produce an LOD | |
that merges adjacent faces that are nearly flat with respect to each other, even at | |
very close render distances. This works well for static meshes, but is often | |
undesirable for use with ``SoftBody3D`` if you want these faces to be able to bend | |
and move with respect to each other, instead of being rendered as a single plane. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, your suggestion sounds good to me. I had assumed that non-wrapping was the convention based on the other lines in this file and the class reference, but wrapping definitely seems preferable. I'll also tweak this slightly to try and better comply with the writing guidelines from the contributing guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all of the files are as good with this as they should be. And the class reference is an exception to this
bb66b85
to
d8845d8
Compare
This mentions that users may want to change the default LOD generation settings when importing meshes for use with SoftBody3D. See godotengine/godot#108025
This mentions that users may want to change the default LOD generation settings when importing meshes for use with SoftBody3D.
See godotengine/godot#108025