Remove OS, GDScript and Object from the list of builtins in syntax highlighting
#739
Conversation
|
@Calinou this is ready to be rebased. (I'm not smart enough to use the GitHub merge editor) |
…tax highlighting OS is a singleton like any other, not a special keyword in GDScript. GDScript is a standard class, not a special keyword either. Object is a Variant type, but it's also a nullable type that is highlighted as a standard object in the Godot script editor.
Calinou
force-pushed
the
syntax-highlighting-os-not-builtin
branch
from
d1fbfcb to
7bf83b3
Compare
| @@ -437,7 +437,7 @@ | |||
| } | |||
| }, | |||
| "builtin_classes": { | |||
| "match": "(?<![^.]\\.|:)\\b(OS|GDScript|Vector2|Vector2i|Vector3|Vector3i|Vector4|Vector4i|Color|Rect2|Rect2i|Array|Basis|Dictionary|Plane|Quat|RID|Rect3|Transform|Transform2D|Transform3D|AABB|String|Color|NodePath|Object|PoolByteArray|PoolIntArray|PoolRealArray|PoolStringArray|PoolVector2Array|PoolVector3Array|PoolColorArray|bool|int|float|Signal|Callable|StringName|Quaternion|Projection|PackedByteArray|PackedInt32Array|PackedInt64Array|PackedFloat32Array|PackedFloat64Array|PackedStringArray|PackedVector2Array|PackedVector2iArray|PackedVector3Array|PackedVector3iArray|PackedVector4Array|PackedColorArray|super)\\b", | |||
| "match": "(?<![^.]\\.|:)\\b(Vector2|Vector2i|Vector3|Vector3i|Vector4|Vector4i|Color|Rect2|Rect2i|Array|Basis|Dictionary|Plane|Quat|RID|Rect3|Transform|Transform2D|Transform3D|AABB|String|Color|NodePath|PoolByteArray|PoolIntArray|PoolRealArray|PoolStringArray|PoolVector2Array|PoolVector3Array|PoolColorArray|bool|int|float|Signal|Callable|StringName|Quaternion|Projection|PackedByteArray|PackedInt32Array|PackedInt64Array|PackedFloat32Array|PackedFloat64Array|PackedStringArray|PackedVector2Array|PackedVector2iArray|PackedVector3Array|PackedVector3iArray|PackedVector4Array|PackedColorArray|super)\\b", | |||
| "name": "entity.name.type.class.builtin.gdscript" | |||
| }, | |||
| "const_vars": { | |||
There was a problem hiding this comment.
OS is a singleton like any other, not a special keyword in GDScript.
@Calinou OS is unusual, as it's all uppercase even though it's a type/class. Are you sure it won't be matched by const_vars and be colored like a constant (such as NAN, INF)?
If so, maybe it should be added as a special case in pascal_case_class, so it's matched as a type even when semantic coloring is disabled/unavailable (doesn't seem like it's supported currently).
Also, I don't know if it's just OS that breaks the norm, or if there's others (except RID, which is already listed above as a basic type).
There was a problem hiding this comment.
Ah OS is definitely not the only one. On a quick look through the class list in stable, there's also these:
IP, JSON, JSONRPC, UPNP, XRVRS
Singletons being colored like a constant is not the worst thing, but at least in the case of JSON and UPNP, they can be constructed with new().
There was a problem hiding this comment.
Yeah, this was why I added OS to this list in the first place.
@static_unloadannotation and Godot 4.3 Variant types to syntax highlighting #738 (can be merged independently, I'll rebase).OS is a singleton like any other, not a special keyword in GDScript. GDScript is a standard class, not a special keyword either. Object is a Variant type, but it's also a nullable type that is highlighted as a standard object in the Godot script editor.