Core: Natively convert enum/BitField with Variant
#101003
Open
+105
−357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
reviewed
Jan 2, 2025
Ivorforce
reviewed
Jan 2, 2025
Repiteo
force-pushed
the
core/variant-native-enum
branch
2 times, most recently
from
625458d to
7a5497f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Repiteo
force-pushed
the
core/variant-native-enum
branch
from
7a5497f to
304aecb
Compare
Ivorforce
reviewed
Jan 5, 2025
Repiteo
force-pushed
the
core/variant-native-enum
branch
from
304aecb to
99a936f
Compare
|
Gave it some more thought, and I'm gonna walk back on trying to handle qualified names automatically. While I'm still largely confident of that implementation, it wasn't air-tight; I'd rather not have the rest of the PR be potentially bogged down by it. I'll revisit that idea in the future, once I have an unambiguously universal solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big reason the above issue happened in the first place is because SO MUCH of the enum binding logic happens after the fact, when the overwhelming majority could be determined via
<type_traits>magic. The only exception seems to be the qualified name, which this PR keeps as an explicitly provided variable; absolutely everything else is now handled natively. While this could probably be implemented more cleanly via C++20 concepts, the entire bindsystem would benefit from them; so for now, SFINAE1 gets the job done.Footnotes
https://en.cppreference.com/w/cpp/language/sfinae ↩