Update Light2D rect_cache
even when not using shadows.
#101110
Merged
+8
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #100922
Regression introduced in #100677
#100677 Updated the
rect_cache
to be in canvas space instead of light local space. However, it mistakenly only did that when shadows were enabled. So unshadowed lights had therect_cache
in the wrong coordinate space.The simplest solution would be to just move the line that updates the
rect_cache
outside the scope of theuse_shadow
block. However, to avoid this sort of confusion, I have updated how the cache is calculated. Instead of setting it in one coordinate space then updating it, we initialize it in the proper coordinate space and only use the local rect in this code path.