Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if setting non-existent shader parameter #103994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Warn if setting non-existent shader parameter #103994

wants to merge 1 commit into from
+12 −0

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 11, 2025

Closes #57971

image

The warning requires parameter cache to be rebuilt (once per ShaderMaterial), which can be costly, so the check is done only in editor builds.

@KoBeWi KoBeWi added this to the 4.x milestone Mar 11, 2025
@akien-mga akien-mga changed the title Warn if setting non-existend shader parameter Warn if setting non-existent shader parameter Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement topic:shaders
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

set_shader_param() doesn't warn about non-existent parameters
2 participants
@KoBeWi @akien-mga