Improve editor 2D/3D main screen auto-switching logic #104010
+29
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In master, Godot has a feature where the main screen tabs may auto-switch depending on the node type being edited.
Seems simple enough. However, the code currently has the following problems:
func _handles
on each plugin, there is hard-coded logic to check for CanvasItem and Node3D.main_screen_switch_current_master.mp4
This PR makes the following changes:
bool EditorMainScreen::can_auto_switch_screens() const
.func _handles
.can_take_away_focus
andcan_lose_focus_on_node_selection
functions.This now works correctly for custom node types and main screen tabs placed to the left of Script:
main_screen_switch_with_pr.mp4