Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSLES cleanup on Android #85944

Closed

Conversation

Alex2782
Copy link
Contributor

@Alex2782 Alex2782 commented Dec 8, 2023

Fixes the following error output:
Bildschirmfoto 2023-12-08 um 23 19 02

I'm not sure if this is critical. This happens when the app is terminated via the "BACK" button. On Android, however, the app is not completely terminated, the app is still in the app list in the background and can be restarted.

@Alex2782 Alex2782 requested a review from a team as a code owner December 8, 2023 22:45
@akien-mga akien-mga added this to the 4.3 milestone Dec 8, 2023
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 8, 2023
@AThousandShips
Copy link
Member

@Alex2782
Copy link
Contributor Author

Alex2782 commented Dec 9, 2023

I think it can be closed here, the extensions from @PierceLBrooks look more extensive.

destroy

We recommend that you explicitly set both the primary object interface and all associated interfaces to NULL as part of your object destruction sequence, which prevents the accidental misuse of a stale interface handle.

Pierce did that too

@Alex2782
Copy link
Contributor Author

Alex2782 commented Dec 9, 2023

--> #85955

@Alex2782 Alex2782 closed this Dec 9, 2023
@Alex2782 Alex2782 deleted the android_openSLES_cleanup branch December 9, 2023 23:54
@AThousandShips AThousandShips removed this from the 4.3 milestone Dec 10, 2023
@AThousandShips AThousandShips added archived and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants