[Label] Handle text as multiple independent paragraphs. #98605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
#79599 now performs much better when you replace the RichTextLabel with a Label and Word autowrap (note that I didn't set up the ScrollContainer). On an i9-13900K, it takes roughly 0.5s to open the licenses dialog with a debug editor build, whereas it took 3.5s previously.
RichTextLabel without threading is still noticeably faster though, even when compared to Label with autowrap disabled. With threading, there is no noticeable pause at all when opening the licenses dialog.
bruvzg
force-pushed
the
lbl_mult_para
branch
2 times, most recently
from
b6c9357 to
c9e631a
Compare
AThousandShips
approved these changes
Nov 14, 2024
bruvzg
force-pushed
the
lbl_mult_para
branch
from
c9e631a to
b329b4a
Compare
akien-mga
approved these changes
Nov 28, 2024
|
Thanks! |
|
@bruvzg this seems to have broken "empty multiline" strings for Peek.2024-12-01.18-44.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #79599