Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjustments for php 8.4 #77

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jklab
Copy link
Contributor

@jklab jklab commented Nov 21, 2024

No description provided.

Copy link
Owner

@godruoyi godruoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. It basically LGTM, just one suggestion.

.github/workflows/test.yml Show resolved Hide resolved
tests/FileLockResolverTest.php Show resolved Hide resolved
Copy link
Owner

@godruoyi godruoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, LGTM

@godruoyi godruoyi merged commit 6e10ab2 into godruoyi:master Nov 22, 2024
6 checks passed
@jklab jklab deleted the chore/enable-php-8.4-support branch November 23, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants