Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preVerifycationGas for UserOperation #7

Merged
merged 2 commits into from
Mar 2, 2023
Merged

add preVerifycationGas for UserOperation #7

merged 2 commits into from
Mar 2, 2023

Conversation

RetricSu
Copy link
Collaborator

@RetricSu RetricSu commented Jan 29, 2023

in order to solve the problem that the charge of the gasless transaction is not equal to the real gas cost, we add the preVerifycationGas back to UserOperation struct

notes:

  • handleOp fn signature changed due to UserOperation structure changed. need to adapt for web and gw.
  • the gas limit check should update to include the preVerifycationGas in web3.
  • web3 must also check if the preVerifycationGas can cover the gas cost gap before submit the tx.
  • the real cost is hard to cover equally, in the current work-flow(simulateValidation and simulateCallContract to get what gas of each part should be ) we end up charging a little more than the real gas cost.

@RetricSu RetricSu marked this pull request as ready for review February 3, 2023 02:39
@Flouse Flouse linked an issue Feb 16, 2023 that may be closed by this pull request
@Flouse Flouse requested review from magicalne and jjyr February 21, 2023 14:11
@Flouse Flouse merged commit 14e0cb2 into main Mar 2, 2023
@Flouse Flouse deleted the preVerifiyGas branch March 2, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gasless feature review report
3 participants