Fixes to Dockerfile #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Install NodeJS 14 - The current recommended version. The old script is depreciated. * Run `useradd` instead of `adduser` - Removes some error messages. * Switch from `pm2 start` script to `pm2-runtime` command. - This is the recommended way to run pm2 in docker. It also stops us from crashing when the app name changes and the log file is missing,
|
Heh, I didn't even see #3 - which is probably a better pull request in general. |
In an effort to more align with goerli#3 goals I switched to node:14-alpine - but I'm not sure if modification of app.json to passing env variables to docker is more or less preferred so here's another option.
|
I was about to make a PR to fix the Dockerfile too, however It looks like nobody is active on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Alpine over Debian
Install NodeJS 14 - The current recommended version. The old script is depreciated.
Run
useraddinstead ofadduser- Removes some error messages.Switch from
pm2 startscript topm2-runtimecommand. - This is the recommended way to run pm2 in docker. It also stops us from crashing when the app name changes and the log file is missing,