Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(checkbox): remove /*HTML*/ within story template strings #323

Merged
merged 1 commit into from
Jul 4, 2024
Merged

refactor(checkbox): remove /*HTML*/ within story template strings #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions libs/ui/checkbox/checkbox.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ type Story = StoryObj<HlmCheckboxComponent>;

export const Default: Story = {
render: () => ({
template: `
/* HTML */
template: /* HTML */ `
<label id='checkbox-label' class='' hlmLabel> Test Checkbox
<hlm-checkbox id='testCheckbox' aria-checked='mixed' aria-label='test checkbox'/>
</label>
Expand All @@ -59,8 +58,7 @@ export const Default: Story = {

export const InsideLabel: Story = {
render: () => ({
template: `
/* HTML */
template: /* HTML */ `
<label id='checkbox-label' class='flex items-center' hlmLabel> Test Checkbox
<hlm-checkbox class='ml-2' id='testCheckbox'/>
</label>
Expand All @@ -70,8 +68,7 @@ export const InsideLabel: Story = {

export const LabeledWithAriaLabeledBy: Story = {
render: () => ({
template: `
/* HTML */
template: /* HTML */ `
<div id='checkbox-label' class='flex items-center'>
<label id='testCheckbox' for='testCheckboxAria' hlmLabel> Test Checkbox </label>
<hlm-checkbox class='ml-2' id='testCheckboxAria' aria-labelledby='testCheckbox'/>
Expand All @@ -82,8 +79,7 @@ export const LabeledWithAriaLabeledBy: Story = {

export const disabled: Story = {
render: () => ({
template: `
/* HTML */
template: /* HTML */ `
<div class='flex items-center'>
<label id='checkbox-label' for='testCheckboxDis1' hlmLabel> Test Checkbox </label>
<hlm-checkbox disabled class='ml-2' id='testCheckboxDis1' aria-labelledby='testCheckbox'/>
Expand All @@ -104,17 +100,15 @@ export const disabled: Story = {

export const disabledWithForms: Story = {
render: () => ({
template: `
/* HTML */
template: /* HTML */ `
<hlm-checkbox-component-tester />
`,
}),
};

export const indeterminate: Story = {
render: () => ({
template: `
/* HTML */
template: /* HTML */ `
<div id='checkbox-label' class='flex items-center'>
<label id='testCheckbox' for='testCheckboxIndeterminate' hlmLabel> Test Checkbox </label>
<hlm-checkbox checked="indeterminate" class='ml-2' id='testCheckboxIndeterminate' aria-labelledby='testCheckbox'/>
Expand Down