Skip to content

Commit

Permalink
Update benchmark.yml
Browse files Browse the repository at this point in the history 
We should only fail during a PR, not during a merge
  • Loading branch information
@ReneWerner87
ReneWerner87 authored Jul 22, 2024
1 parent 8e1470f commit ef07360
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/benchmark.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
external-data-json-path: ./cache/benchmark-data.json
# Save the data to external file (cache)
save-data-file: true
fail-on-alert: true
fail-on-alert: false
github-token: ${{ secrets.GITHUB_TOKEN }}
summary-always: true
alert-threshold: "150%"
Expand All @@ -89,7 +89,7 @@ jobs:
tool: 'go'
output-file-path: output.txt
benchmark-data-dir-path: "benchmarks"
fail-on-alert: true
fail-on-alert: false
github-token: ${{ secrets.GITHUB_TOKEN }}
comment-on-alert: true
summary-always: true
Expand All @@ -105,4 +105,4 @@ jobs:
if: ${{ github.ref_name == 'main' }}
with:
path: ./cache
key: ${{ steps.get-main-branch-sha.outputs.sha }}-${{ runner.os }}-${{ steps.system-info.outputs.cpu-model }}-benchmark
key: ${{ steps.get-main-branch-sha.outputs.sha }}-${{ runner.os }}-${{ steps.system-info.outputs.cpu-model }}-benchmark

1 comment on commit ef07360

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: ef07360 Previous: 1c52689 Ratio
Benchmark_Utils_GetOffer/1_parameter 225.1 ns/op 0 B/op 0 allocs/op 137 ns/op 0 B/op 0 allocs/op 1.64
Benchmark_CORS_NewHandlerPreflight 1159 ns/op 104 B/op 5 allocs/op 766.5 ns/op 0 B/op 0 allocs/op 1.51
Benchmark_CORS_NewHandlerPreflightSingleOrigin 1168 ns/op 104 B/op 5 allocs/op 758.5 ns/op 0 B/op 0 allocs/op 1.54
Benchmark_CORS_NewHandlerPreflightWildcard 1068 ns/op 104 B/op 5 allocs/op 697.1 ns/op 0 B/op 0 allocs/op 1.53

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.