✅ test: Fix failing CSRF tests #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed on Test_Client_Agent_Dest and Session middleware tests. There were some races reported logs. |
ReneWerner87
approved these changes
Nov 11, 2023
gaby
approved these changes
Nov 17, 2023
A test validating that expired tokens fail was hitting a race condition with garbage collection. Sometimes, an assertion that expects memory storage GC to have triggered happens too quickly, causing the assertion to fail. Give the GC a little bit more time to process before asserting.
sixcolors
reviewed
Nov 19, 2023
nickajacks1
force-pushed
the
testfail-csrf
branch
2 times, most recently
from
5b39e15 to
697bcde
Compare
sixcolors
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A test validating that expired tokens fail was hitting a race condition with garbage collection. Sometimes, an assertion that expects memory storage GC to have triggered happens too quickly, causing the assertion to fail. Give the GC a little bit more time to process before asserting.
Type of change
Checklist: