Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Linters in Cassandra, Clickhouse & Opentsdb #1252

Closed
wants to merge 18 commits into from
Closed

Fixing Linters in Cassandra, Clickhouse & Opentsdb #1252

wants to merge 18 commits into from

Conversation

coolwednesday
Copy link
Contributor

@coolwednesday coolwednesday commented Nov 28, 2024 •
edited
Loading

Description:

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

Umang01-hash
Umang01-hash requested changes Nov 28, 2024
View reviewed changes
pkg/gofr/datasource/opentsdb/opentsdb.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/preprocess.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/response.go Outdated Show resolved Hide resolved
ccoVeille
ccoVeille reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring 👍

Some minor remarks

pkg/gofr/datasource/opentsdb/opentsdb_test.go Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/preprocess.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/response.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb.go Show resolved Hide resolved
ccoVeille
ccoVeille reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may think I'm against these changes 😅

But, I'm not 😁

pkg/gofr/datasource/opentsdb/interface.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/interface.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb_test.go Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/opentsdb_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/opentsdb/response.go Outdated Show resolved Hide resolved
Umang01-hash
Umang01-hash previously approved these changes Dec 4, 2024
View reviewed changes
@coolwednesday
Copy link
Contributor Author

This PR is getting closed, as we believe that each datasource changes must be handled in different PRs. Hence consequent PRs, addressing each datasource will be created instead of this.

@ccoVeille ccoVeille mentioned this pull request Dec 5, 2024
Merged
4 tasks
@ccoVeille
Copy link
Contributor

ccoVeille commented Dec 5, 2024 •
edited
Loading

Split into

This was referenced Dec 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipul-rawat vipul-rawat vipul-rawat left review comments

@ccoVeille ccoVeille ccoVeille approved these changes

@Umang01-hash Umang01-hash Umang01-hash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coolwednesday @ccoVeille @vipul-rawat @Umang01-hash