Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linters and test in pubsub & dgraph datasources #1254

Closed
wants to merge 22 commits into from
Closed

Fix linters and test in pubsub & dgraph datasources #1254

wants to merge 22 commits into from
+557 −130

Conversation

Umang01-hash
Copy link
Contributor

@Umang01-hash Umang01-hash commented Nov 28, 2024 •
edited
Loading

Pull Request Template

Description:

  • Resolve linters and failing tests for Dgraph & PubSub datasources

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

ccoVeille
ccoVeille reviewed Nov 28, 2024
View reviewed changes
pkg/gofr/datasource/dgraph/dgraph_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/dgraph/dgraph_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/google/google_test.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/google/google_test.go Outdated Show resolved Hide resolved
aryanmehrotra
aryanmehrotra requested changes Dec 3, 2024
View reviewed changes
pkg/gofr/datasource/dgraph/dgraph.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/eventhub/eventhub.go Outdated Show resolved Hide resolved
pkg/gofr/datasource/pubsub/google/google_test.go Outdated Show resolved Hide resolved
@aryanmehrotra
Copy link
Member

Please create separate PR for all the data source separately

@Umang01-hash Umang01-hash deleted the fix/datasources branch December 6, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

@aryanmehrotra aryanmehrotra aryanmehrotra requested changes

@vipul-rawat vipul-rawat vipul-rawat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Umang01-hash @aryanmehrotra @ccoVeille @vipul-rawat