-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove go.mod files from examples #1256
base: development
Are you sure you want to change the base?
Conversation
This is the "what?", but nothing explain the "why?" I mean, you explain what the commit is about, but I have no idea why you do such changes |
Did it regarding this comment: |
github.com/hashicorp/golang-lru/v2 v2.0.7 // indirect | ||
github.com/jlaffaye/ftp v0.2.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be part of the gofr go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the go.mod are removed in examples, isn't normal things are going up, and are added to main one no?
If this is the problem, we can leave a go.mod at the root of examples
Another solution is to move the examples folder into a testdata folder, as it's a special folder
Pull Request Template
Description:
go.mod
files from remaining examples.Checklist:
goimport
andgolangci-lint
.Thank you for your contribution!