Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove go.mod files from examples #1256

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Conversation

Umang01-hash
Copy link
Contributor

@Umang01-hash Umang01-hash commented Nov 29, 2024

Pull Request Template

Description:

  • Remove go.mod files from remaining examples.

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@ccoVeille
Copy link
Contributor

Remove go.mod files from remaining examples.

This is the "what?", but nothing explain the "why?"

I mean, you explain what the commit is about, but I have no idea why you do such changes

@Umang01-hash
Copy link
Contributor Author

Remove go.mod files from remaining examples.

This is the "what?", but nothing explain the "why?"

I mean, you explain what the commit is about, but I have no idea why you do such changes

Did it regarding this comment:

#1225 (comment)

github.com/hashicorp/golang-lru/v2 v2.0.7 // indirect
github.com/jlaffaye/ftp v0.2.0 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be part of the gofr go.mod

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the go.mod are removed in examples, isn't normal things are going up, and are added to main one no?

If this is the problem, we can leave a go.mod at the root of examples

Another solution is to move the examples folder into a testdata folder, as it's a special folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants