-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only upload builder artifacts from workflow runs triggered after merge #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe
reviewed
Feb 13, 2024
James-Mart
force-pushed
the
fix-workflow-runs
branch
5 times, most recently
from
February 15, 2024 17:30
6d86eb1
to
2fce398
Compare
James-Mart
force-pushed
the
fix-workflow-runs
branch
from
February 15, 2024 18:28
2fce398
to
6b5948f
Compare
James-Mart
force-pushed
the
fix-workflow-runs
branch
2 times, most recently
from
February 15, 2024 20:45
b1e499a
to
2f875a1
Compare
James-Mart
force-pushed
the
fix-workflow-runs
branch
from
February 15, 2024 21:36
2f875a1
to
dff2891
Compare
James-Mart
changed the title
Fix workflow runs
Only upload builder artifacts from workflow runs triggered after merge
Feb 16, 2024
swatanabe
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ghcr.io
, and will instead only be uploaded as local artifacts to the github action.ghcr.io
. And if it pulls fromghcr.io
, it knows how to look up the latest image (not using alatest
tag).builder
workflows were combined into one, parameterized by the desired base version of ubuntu.Notes on centralizing dispatching
There were lots of complexities trying to manage each of the separate workflows and trigger them at the correct times. For example, if files were changes that would cause the
psibase_contributor
image to be rebuilt, then I should trigger that workflow. But I should not trigger it if files were also changed that would trigger a rebuild of the2204 builder
image, since that is a dependency of the psibase_contributor and therefore psibase_contributor would need to run afterwards. Building such logic like this into a workflow file using normal path exclusion doesn't work the way I expected, and I decided that the most straightforward way to accomplish our complicated build strategies here is to simply extract all the logic into a central_dispatcher.yml
workflow that figures everything out and dispatches the workflows appropriately.