Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for std::chrono::duration in tables and action arguments #449

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Add support for std::chrono::duration in tables and action arguments #449

merged 1 commit into from
Jul 6, 2023

Conversation

swatanabe
Copy link
Collaborator

duration<Rep, Period> is packed as Rep.
clio_unwrap_packable is unusable for two reasons

  • Adding declarations to namespace std (for ADL) is not allowed
  • duration does not provide a way to get a reference to Rep

@swatanabe
Add support for std::chrono::duration. Also split up the test cases i…
bea7a4f 
…nto multiple translation units, because the memory and time for compiling are getting a bit ridiculous.
@swatanabe swatanabe requested a review from James-Mart July 5, 2023 22:03
@swatanabe swatanabe merged commit 5a725ea into main Jul 6, 2023
2 checks passed
@swatanabe swatanabe deleted the fracpack-chrono branch July 6, 2023 21:55
@James-Mart James-Mart added the Dev Experience Related to the experience of developers label Aug 30, 2023
@James-Mart James-Mart changed the title Add support for std::chrono::duration. Add support for std::chrono::duration in tables and action arguments Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Mart James-Mart James-Mart approved these changes

Assignees
No one assigned
Labels
Dev Experience Related to the experience of developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swatanabe @James-Mart