Adding no-ancestor http header to apps (so they're guaranteed to be at _top) #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe
reviewed
Mar 6, 2024
| @@ -11,7 +11,13 @@ namespace psibase | |||
| { | |||
| std::string name; | |||
| std::string value; | |||
|
|
|||
| friend bool operator==(const HttpHeader& lhs, const HttpHeader& rhs) | |||
| auto result = iface.serveSys(std::move(req)); | ||
| if (result && !result->headers.empty() && serviceName != "common-sys") | ||
| abortMessage("service " + service.str() + " attempted to set an http header"); | ||
|
|
||
| if (reqTarget.size() == 0 || reqTarget.starts_with("/index.html")) |
There was a problem hiding this comment.
Do you really mean starts_with? ends_with or == would make more sense to me.
Comment on lines
+91
to
+92
| HttpHeader frameAncestorHeader = {"Content-Security-Policy", "frame-ancestors 'none';"}; | ||
| auto pos = std::find(result->headers.begin(), result->headers.end(), frameAncestorHeader); |
There was a problem hiding this comment.
This will miss many valid ways to spell the header.
Also, if the service has already provided a different value of frame-ancestors, do we still want to add frame-ancestors 'none'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.