-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-Admin app improvements #761
Conversation
Velua
commented
Jun 19, 2024
•
edited
Loading
edited
- Remove in house hash routing, adopt React Router Hash Routing.
- Remove custom hooks for queries and adopt React Query.
- Zod type API responses / Centralised all chain API requests.
- Add new dashboard page alongside graphana
- Remove old boot page / form
- Add setup / Join wizard
This looks very awesome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left various feedback on this issue that I gathered while using the interface. Nothing I'd block this PR over.
Only thing that seems necessary to fix before merge (from a usability perspective) is the zod parse error that prevents the chain from booting.
--EDIT--
|
--EDIT--
|
If that's happening, it's probably a bug on the native side. The |
Yeah I think the solution here is just to prevent crossing lanes,
It's awkward if persistent connections get both only to reconnect again anyway.
|
It's a native bug that seems to be caused by having multiple entries for |
Although why even bother disconnecting if it's a transient connection, since it'll just come back again, right? Unless we can blacklist somehow @swatanabe |
OUTPUT ${SERVICE_DIR}/Default.psi | ||
NAME Default | ||
OUTPUT ${SERVICE_DIR}/DevDefault.psi | ||
NAME DevDefault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
psibase boot
needs to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tester as well, yeah?
psibase/rust/psibase/src/main.rs
Line 646 in 98f3198
let default_services = vec!["Default".to_string()]; |
and
psibase/rust/psibase/src/tester.rs
Line 62 in 98f3198
let default_services: Vec<String> = vec!["Default".to_string()]; |