Add more tests to CI #792
Merged
Add more tests to CI #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe
reviewed
Jul 30, 2024
swatanabe
reviewed
Jul 30, 2024
|
Merge conflicts |
Hmmm... 🤔 I don't see any... Where?
👍 Tracked on #794 |
Git can "resolve" the merge, but check the cicd errors, or just merge and try building. |
swatanabe
approved these changes
Aug 5, 2024
James-Mart
added
the
no-log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@swatanabe I took the opportunity to fix the
cargo buildfrom the rust root folder, added it as a ctest command (which is a bit odd maybe? but is there a better place to add it?) and added a couple more service examples that we tend to keep up-to-date. WDYT?If you are happy with it feel free to merge to your pr #790 and merge altogether.