Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chainmail: Rewrite in Rust #826

Merged
merged 19 commits into from
Sep 18, 2024
Merged

Chainmail: Rewrite in Rust #826

merged 19 commits into from
Sep 18, 2024

Conversation

cool-ant
Copy link
Member

@cool-ant cool-ant commented Sep 3, 2024 •
edited
Loading

  • rewrite service in Rust

@cool-ant cool-ant force-pushed the mm/chainmail-archive branch 2 times, most recently from 31c2b51 to df9f569 Compare September 6, 2024 01:12
@cool-ant cool-ant marked this pull request as ready for review September 6, 2024 16:55
@cool-ant cool-ant changed the title Chainmail: adding archive feature Chainmail: converting from CPP to Rust service (in prep for archive functionality) Sep 6, 2024
@James-Mart James-Mart changed the title Chainmail: converting from CPP to Rust service (in prep for archive functionality) Chainmail: Rewrite in Rust Sep 6, 2024
@James-Mart James-Mart added the System app Related to system services and their apps/plugins label Sep 6, 2024
James-Mart
James-Mart previously requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@James-Mart James-Mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should delete the Webmail/src/Webmail.cpp and Webmail/CMakeLists.txt files which were only used when the service was implemented in C++. The header file you could leave for the C++ wrapper.

rust/psibase/src/services/r_events.rs Outdated Show resolved Hide resolved
services/user/Webmail/Cargo.toml Outdated Show resolved Hide resolved
services/user/Webmail/service/src/lib.rs Outdated Show resolved Hide resolved
services/user/Webmail/service/src/lib.rs Outdated Show resolved Hide resolved
This was referenced Sep 11, 2024
Closed
Closed
swatanabe
swatanabe reviewed Sep 16, 2024
View reviewed changes
services/user/Webmail/service/src/lib.rs Outdated Show resolved Hide resolved
services/user/Webmail/service/src/lib.rs Outdated Show resolved Hide resolved
services/user/Webmail/service/src/lib.rs Outdated Show resolved Hide resolved
services/user/Webmail/service/src/lib.rs Outdated Show resolved Hide resolved
services/user/Webmail/service/src/lib.rs Outdated Show resolved Hide resolved
rust/psibase/src/services/events.rs Outdated Show resolved Hide resolved
@swatanabe swatanabe dismissed James-Mart’s stale review September 18, 2024 18:20

appears to be addressed

@cool-ant cool-ant merged commit 5a316ee into main Sep 18, 2024
4 checks passed
@cool-ant cool-ant deleted the mm/chainmail-archive branch September 18, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatanabe swatanabe swatanabe approved these changes

@James-Mart James-Mart Awaiting requested review from James-Mart

Assignees
No one assigned
Labels
System app Related to system services and their apps/plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cool-ant @swatanabe @James-Mart