Workshop app - Phase 1 #831
Conversation
|
@brandonfancher & @Velua can you please review the UI structure, the form hooks etc. To make sure it is aligned with the other frontend apps patterns? @James-Mart package wip, need to sync with you! |
sparkplug0025
force-pushed
the
sparkplug0025/app-registry
branch
from
8eafc2e
to
0d234b5
Compare
sparkplug0025
force-pushed
the
sparkplug0025/app-registry
branch
from
0d234b5
to
1080ead
Compare
| } | ||
|
|
||
| #[action] | ||
| fn storeSys(path: String, contentType: String, content: Hex<Vec<u8>>) { |
There was a problem hiding this comment.
storeSys (and therefore the WebContentTable) should be in the query service alongside serveSys.
There was a problem hiding this comment.
when I read query my first instinct was that it is a read only service (I thought the same when I saw the example named r-<package>). If we are adding the storesys it would go against a query or a read only service. So what is the definition of the query service on the package?
There was a problem hiding this comment.
A query service's primary job is to handle HTTP requests. In this mode it is read-only. The data is stored in the query service because it is only used for the HTTP interface. It's essentially static content associated with the service.
There was a problem hiding this comment.
I think I might prefer calling it an "http-server" or something. Query / RPC service don't seem as readily understandable.
| /// Holds metadata for a registered app | ||
| #[table(name = "AppMetadataTable", index = 0)] | ||
| #[derive(Debug, Clone, Fracpack, ToSchema, Serialize, Deserialize, SimpleObject)] | ||
| pub struct AppMetadata { |
There was a problem hiding this comment.
These weren't in the github issue (until right now because I just added them), but could you also add
tags: List<String>- Devs can add up to 3 tags that can further be used to categorize the applicationcreated: TimePointSec- This can be set with gettingcurrentBlock().timefrom theTransactservice. Tracks the unix time in seconds that the app was registered.
|
This looks good. I see that some of the UI and account selection controls were borrowed from webmail/chainmail. There is a newer in-progress (will be merged soon) branch of that that actually queries available accounts and changes the account with supervisor from the dropdown (vs. using the mocked out accounts list fixture.) That can be found in the UI code wise, everything looks great! |
|
Dark mode, pretty please! |
|
@swatanabe can you please help me troubleshoot why I'm receiving the error below when running
|
It's triggered by When trying to resolve "r-workshop" we look at the workspace members and the immediate dependencies of "workshop". "r-workshop" isn't in either. |
wip...