Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating X-admin's yarn.lock so we don't see it updated every time we build #839

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

cool-ant
Copy link
Member

@cool-ant cool-ant commented Sep 5, 2024

Not sure this will stop the problem, but it seems to be the only one that gets updated eveyr build, so worth a shot.

@James-Mart
Copy link
Member

James-Mart commented Sep 5, 2024

Thank the lord.

---- EDIT
Oh, just looked at your change, is this just committing what was automatically built for you? If so, I don't think this will work. I've committed it many times, so I think differences in some of our development environments are fighting over this lock file

@cool-ant cool-ant merged commit a5fdb11 into main Sep 5, 2024
4 checks passed
@cool-ant cool-ant deleted the mm/x-admin-yarn-lock branch September 5, 2024 22:15
@swatanabe
Copy link
Collaborator

swatanabe commented Sep 6, 2024

The version committed in this PR matches yarn 1.22.22. The previous version was what I was seeing with yarn 1.22.21.

@James-Mart
Copy link
Member

The version committed in this PR matches yarn 1.22.22. The previous version was what I was seeing with yarn 1.22.21.

Perhaps we should align on a specific yarn version. The builders currently just use npm i -g yarn

@James-Mart James-Mart added the no-log Any issue/pr with this label will automatically be excluded from autogenerated changelog label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-log Any issue/pr with this label will automatically be excluded from autogenerated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants