Renaming Webmail to Chainmail #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonfancher
approved these changes
Sep 19, 2024
James-Mart
reviewed
Sep 23, 2024
| @@ -20,7 +20,7 @@ export const App = () => { | |||
| const init = async () => { | |||
| await supervisor.onLoaded(); | |||
| supervisor.preLoadPlugins([{ service: "branding" }]); | |||
| await getNetworkName(); | |||
| setTimeout(getNetworkName, 1500); | |||
There was a problem hiding this comment.
Good catch; I did that for the demo to emulate what won't work now because... ?Supervisor?
So no, it wasn't working.
I'll create a PR to reverse this change.
There was a problem hiding this comment.
Nothing to do with Supervisor. I just couldn't verify this yet without post-install steps for chainmail
James-Mart
added
the
System app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This touched a lot of files, so splitting out the rename from the archiving functionality PR