Chainmail: implement archive functionality in service #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cool-ant
force-pushed
the
mm/chainmail-implement-archive
branch
from
5e57a90
to
981aac6
Compare
cool-ant
force-pushed
the
mm/chainmail-implement-archive
branch
from
981aac6
to
879e362
Compare
James-Mart
reviewed
Sep 30, 2024
… loading issue; then test Archive and archived message retrieval
…ofractally/psibase into mm/chainmail-implement-archive
brandonfancher
approved these changes
Oct 9, 2024
James-Mart
reviewed
Oct 10, 2024
|
|
||
| return Some(HttpReply { | ||
| status: 200, | ||
| contentType: request.contentType.clone(), |
There was a problem hiding this comment.
No contentType header is set on the HTTP request that originates from the getJson plugin request. You should probably just use "application/json" explicitly.
| // method: "unsave", | ||
| // params: [id], | ||
| // }); | ||
| // TODO: Improve error detection. This promise resolves with success before the transaction is pushed. |
There was a problem hiding this comment.
Is it? The tx is not applied before promise resolution, but the tx is supposed to be pushed as part of the resolution of the plugin call (before resolving this promise).
| sender: String, | ||
| subject: String, | ||
| body: String, | ||
| } |
There was a problem hiding this comment.
You can add
[package.metadata.component.bindings]
derives = ["serde::Deserialize"]
To the plugin's Cargo.toml in order for the Message struct generated bindings to derive from Deserialize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #821 (archive; save will be a separate item)
Notes: