Default deploy chainmail #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
added
the
System app
swatanabe
reviewed
Sep 24, 2024
…data.psibase' table.
James-Mart
force-pushed
the
default-deploy-chainmail
branch
from
ac2c9e0
to
66b72fb
Compare
swatanabe
reviewed
Sep 25, 2024
swatanabe
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the ChainMail app is deployed to the chain by default.
To accomplish this, the new functionality in
cargo-psibasethat allows for UI and postinstall scripts to be specified is leveraged in chainmail.Also, this PR introduces a new CMake function
cargo_psibase_packagethat allows psibase devs to tell CMake about packages that are built usingcargo-psibase packagerather than using the CMakepsibase_packagefunction. Therefore cargo-psibase-managed packages can be integrated into the regular build system just like the other packages.