Chainmail: patching line of debugging code #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
reviewed
Sep 25, 2024
| @@ -20,7 +20,7 @@ export const App = () => { | |||
| const init = async () => { | |||
| await supervisor.onLoaded(); | |||
| supervisor.preLoadPlugins([{ service: "branding" }]); | |||
| setTimeout(getNetworkName, 1500); | |||
| await getNetworkName(); | |||
There was a problem hiding this comment.
If I understood your other comment correctly, await here was not working at some point.
But I assume from this change that it is now working, yeah?
…e requested preload has completed
James-Mart
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly included a debugging line I meant to revert before the PR. It got missed and committed by mistake. This just reverses that line.