Make 'Sites' the default webserver app #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of a required 'sender', storeSys always called on the sites service.
James-Mart
commented
Sep 26, 2024
| E -->|no| G{{target begins with '/common'?}} -->|yes| H['common-api' service's serveSys action] | ||
| G -->|no| I{{on a subdomain?}} -->|no| 404 | ||
| I -->|yes| J{{Has registered server?}} -->|no| 404 | ||
| J -->|yes| L[registered server's serveSys action] |
swatanabe
reviewed
Sep 26, 2024
doc/psidk/src/development/services/cpp-service/reference/web-services.md
Outdated
Show resolved
Hide resolved
swatanabe
reviewed
Sep 27, 2024
swatanabe
approved these changes
Sep 27, 2024
James-Mart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the Sites app the default server for storing/serving UI artifacts, instead of requiring the same
storeSysboilerplate to be used within every app.Accordingly, both the package infra and psibase CLI tool were updated to call
storeSysonsites.Furthermore, I needed to add a Sites plugin to accommodate the Branding app, which was previously calling its own
storeSysaction manually.I removed the
storageInterface,WebContentRow, andserveContentas interfaces, since they are no longer needed.Docs changes
I also updated StorageInterface docs, CLI docs, and package support docs.
Benefits